Add "Settings" page link to plugin actions#92
Merged
peterwilsoncc merged 3 commits intodevelopfrom Jul 21, 2025
Merged
Conversation
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good, thank you.
I've dropped a nitpick and question inline.
| 'settings' => sprintf( | ||
| '<a href="%s"> %s </a>', | ||
| esc_url( admin_url( 'tools.php?page=block-catalog-tools' ) ), | ||
| esc_html__( 'Settings', 'block-catalog' ) |
Contributor
There was a problem hiding this comment.
I might be wrong here, so feel free to push back, but I'm wondering if this would be best as Index Blocks or similar as it's not really a settings page.
Let me know your thoughts.
Contributor
Author
There was a problem hiding this comment.
@peterwilsoncc I updated it to Index Posts same as the button text on the index page (/wp-admin/tools.php?page=block-catalog-tools):
Let me know if that makes sense!
Contributor
There was a problem hiding this comment.
Index Posts is great, thank you!
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
peterwilsoncc
approved these changes
Jul 21, 2025
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good and tests well, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #72
How to test the Change
/wp-admin/plugins.phppage of your site.Block Catalogplugin is not active, then activate it.Settingslink right below the plugin name, beforeDeactivatelink.Settingslink, you should be redirected to/wp-admin/tools.php?page=block-catalog-toolspage.Changelog Entry
Credits
Props @sanketio
Checklist: